Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: turn debug message about invalid constraint into warning #6730

Merged

Conversation

finswimmer
Copy link
Member

Poetry skips dependencies which are defined with an invalid version constraint. At the moment this is only visible as a debug message. Because skipping dependencies is crucial, this PR change to log message to a warning.

Resolves: #6434

@finswimmer finswimmer requested a review from a team October 7, 2022 09:26
@neersighted neersighted added area/error-handling Bad error messages/insufficient error handling impact/backport Requires backport to stable branch impact/changelog Requires a changelog entry backport/1.2 labels Oct 7, 2022
@neersighted neersighted merged commit 4578c6f into python-poetry:master Oct 7, 2022
@poetry-bot
Copy link

poetry-bot bot commented Oct 7, 2022

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6730-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4578c6f4be6b8f2eb92d43d6815fd9243d50a087
# Push it to GitHub
git push --set-upstream origin backport-6730-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport-6730-to-1.2.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/error-handling Bad error messages/insufficient error handling impact/backport Requires backport to stable branch impact/changelog Requires a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required dependency missing from lockfile
4 participants